Skip to main content

Code Review

Improve knowledge and processes for writing code that scales and is easy to change

Context

Review

Tips for useful, respectful code reviews:

  • Assume competence (author may have a different context)
  • Provide specific, actionable feedback
  • Focus on the code (avoid personal criticism)
  • Clearly mark nitpicks & optional comments
  • Provide rationale (e.g refs to a style guide)

How to make better code reviews

Metrics

  • Velocity
  • Reusability
  • Sprint Burndown
  • Release Burndown
  • Cycle Time
  • Cumulative Flow
  • Flow Efficiency
  • Code Coverage
  • Code Stability
  • Code Simplicity
  • Code Churn

Reusability

  1. Templating — Reusing code by wrapping it up inside of a component
  2. Configuration — Using configuration props to allow for varying behaviour
  3. Adaptability — Allowing components to become future-proof
  4. Inversion — Letting other components control the process
  5. Extension — Using reusability throughout our component
  6. Nesting — Creating powerful hierarchies of components

What is the most important question you could ask yourself to make progress?